tokers commented on a change in pull request #742:
URL:
https://github.com/apache/apisix-ingress-controller/pull/742#discussion_r757197791
##########
File path: pkg/ingress/compare.go
##########
@@ -42,7 +43,7 @@ func (c *Controller) CompareResources(ctx context.Context)
error {
consumerMapA6 = make(map[string]string)
)
// watchingNamespace == nil means to monitor all namespaces
- if c.watchingNamespace == nil {
+ if !validation.HasValueInSyncMap(c.watchingNamespace) {
Review comment:
OK, I check out the code base I found there is only place use the
`CompareResources` and at that time the controllers are not launched.
So let's just add some comments on this method so that once this method is
called in the runtime, writers won't make a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
