[GitHub] [apisix] crazyMonkey1995 commented on a change in pull request #6292: fix(traffic-split): failed to match rule when the first rule failed

Thu, 10 Feb 2022 22:41:48 -0800 


crazyMonkey1995 commented on a change in pull request #6292:
URL: https://github.com/apache/apisix/pull/6292#discussion_r804388373



##########
File path: apisix/plugins/traffic-split.lua
##########
@@ -238,6 +238,7 @@ function _M.access(conf, ctx)
 
     for _, rule in ipairs(conf.rules) do
         if not rule.match then
+            match_passed = true

Review comment:
       But if match_passed is set to false on the first loop, it will remain 
false instead of true on the second loop
   
![image](https://user-images.githubusercontent.com/21658981/153547615-8f96d35d-57bd-43e7-a937-04260695c216.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to