starsz commented on a change in pull request #6292:
URL: https://github.com/apache/apisix/pull/6292#discussion_r805163664
##########
File path: t/plugin/traffic-split5.t
##########
@@ -311,3 +311,110 @@ passed
}
--- response_body
1970, 1970, 1971, 1972, 1972, 1973
+
+
+
+=== TEST 5: set upstream(multiple rules, the first rule has the match
attribute and the second rule does not) and add route
+--- config
+ location /t {
+ content_by_lua_block {
+ local json = require("toolkit.json")
+ local t = require("lib.test_admin").test
+ local data = {
+ uri = "/hello",
+ plugins = {
+ ["traffic-split"] = {
+ rules = {
+ {
+ match = { {
+ vars = { { "arg_id", "==", "1" } }
+ } },
+ weighted_upstreams = {
+ {
+ upstream = {
+ name = "upstream_A",
+ type = "roundrobin",
+ nodes = {
+ ["127.0.0.1:1970"] = 1
+ }
+ },
+ weight = 1
+ }
+ }
+ },
+ {
+ weighted_upstreams = {
+ {
+ upstream = {
+ name = "upstream_B",
+ type = "roundrobin",
+ nodes = {
+ ["127.0.0.1:1971"] = 1
+ }
+ },
+ weight = 1
+ },
+ {
+ weight = 1
+ }
+ }
+ }
+ }
+ }
+ },
+ upstream = {
+ type = "roundrobin",
+ nodes = {
+ ["127.0.0.1:1972"] = 1
+ }
+ }
+ }
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ json.encode(data)
+ )
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 6: first rule match failed and the second rule match success
+--- config
+ location /t {
+ content_by_lua_block {
+ local http = require "resty.http"
+ local httpc = http.new()
+
+ local uri = "http://127.0.0.1:"; .. ngx.var.server_port ..
"/hello?id=1"
+ local ports = {}
+ local res, err
+ for i = 1, 2 do
+ res, err = httpc:request_uri(uri)
+ local port = tonumber(res.body)
+ ports[i] = port
+ end
+ table.sort(ports)
Review comment:
I think we can omit this call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
