Belyenochi commented on a change in pull request #896:
URL:
https://github.com/apache/apisix-ingress-controller/pull/896#discussion_r820348411
##########
File path: Makefile
##########
@@ -19,6 +19,7 @@ default: help
VERSION ?= 1.4.0
RELEASE_SRC = apache-apisix-ingress-controller-${VERSION}-src
LOCAL_REGISTRY="localhost:5000"
+CUSTOM_REGISTRY ?= ""
Review comment:
> IMO, it would be better to move the kind-up from the prerequisite of
push-images to the e2e-test. Since the users may indeed have a registry at
localhost:5000. Users can then run the e2e like this: build the images, export
the REGISTRY env var, run `make push-images`, and then execute ginkgo directly.
Or we could provide a new entry such as `e2e-test-local` just like the e2e-test
but without kind-up.
@lingsamuel Thanks for the suggestion, e2e-test-local has been re-added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
