tao12345666333 commented on a change in pull request #896:
URL:
https://github.com/apache/apisix-ingress-controller/pull/896#discussion_r820424984
##########
File path: Makefile
##########
@@ -63,52 +63,57 @@ lint:
unit-test:
go test -cover -coverprofile=coverage.txt ./...
-### e2e-test: Run e2e test cases (kind is required)
+### e2e-test: Run e2e test cases (in existing clusters directly)
.PHONY: e2e-test
-e2e-test: ginkgo-check push-images-to-kind
+e2e-test: ginkgo-check push-images
kubectl apply -k $(PWD)/samples/deploy/crd
cd test/e2e \
&& go mod download \
+ && export REGISTRY=$(REGISTRY)
Review comment:
```suggestion
&& export REGISTRY=$(REGISTRY) \
```
need to be modified here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
