kwanhur commented on code in PR #6750:
URL: https://github.com/apache/apisix/pull/6750#discussion_r844786911
##########
apisix/plugins/response-rewrite.lua:
##########
@@ -115,6 +155,19 @@ function _M.check_schema(conf)
end
end
+ if conf.filters then
+ for _, filter in ipairs(conf.filters) do
+ if filter.regex == "" then
Review Comment:
It seems not good to skip this test, although `required` on `filter.regex`,
but it can also fill with empty string `""`.
If could place non-empty rule, so we can skip this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
