kwanhur commented on code in PR #6750:
URL: https://github.com/apache/apisix/pull/6750#discussion_r845824499


##########
apisix/plugins/response-rewrite.lua:
##########
@@ -126,6 +177,25 @@ function _M.body_filter(conf, ctx)
         return
     end
 
+    if conf.filters then
+
+        local body = core.response.hold_body_chunk(ctx)
+        if not body then
+            return
+        end
+
+        for _, filter in ipairs(conf.filters) do
+            if filter.scope == "once" then
+                body = re_sub(body, filter.regex, filter.replace, 
filter.options)

Review Comment:
   This result `err` places on `check_schema`, had checked it.
   
   If check on `body_filter` phase, `err` exception found, should update 
response status code like `500`, but it's too late here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to