tao12345666333 commented on code in PR #975:
URL:
https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r854700674
##########
pkg/kube/translation/annotations/redirect.go:
##########
@@ -15,11 +15,15 @@
package annotations
import (
+ "strconv"
+
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
const (
_httpToHttps = AnnotationsPrefix + "http-to-https"
+ _uri = AnnotationsPrefix + "uri"
+ _retCode = AnnotationsPrefix + "ret_code"
Review Comment:
I tend to use
`k8s.apisix.apache.org/permanent-redirect` for uri
`k8s.apisix.apache.org/permanent-redirect-code` for ret_code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
