tao12345666333 commented on code in PR #975:
URL:
https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r854811481
##########
test/e2e/suite-annotations/redirect.go:
##########
@@ -90,6 +90,39 @@ spec:
resp.Header("Location").Equal("https://httpbin.org/sample";)
})
+ ginkgo.It("redirect permanent-redirect in ingress networking/v1",
func() {
Review Comment:
We need more test cases to cover `extensions/v1beta1` and
`networking/v1beta1` Ingress.
And should increase the verification of the redirected result.
For example, redirect it to https://httpbin.org/get to check if the result
is as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
