spacewander commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r868722806
########## apisix/stream/xrpc/runner.lua: ########## @@ -70,9 +74,49 @@ local function put_req_ctx(session, ctx) end +local function filter_logger(ctx, logger) + if not logger or not logger.filter or #logger.filter == 0 then + return false + end + + local expr, err = expr.new(logger.filter) Review Comment: Better avoid using the module name as the var name. And let's introduce a cache to avoid creating new obj per operations in the next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
