tzssangglass commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r869831020
########## apisix/stream/xrpc/runner.lua: ########## @@ -71,9 +79,58 @@ local function put_req_ctx(session, ctx) end +local function filter_logger(ctx, logger) + if not logger then + return false + end + + if not logger.filter or #logger.filter == 0 then + -- no valid filter, default execution plugin + return true + end + + -- key and version are divided by per-logger level + local key = "xrpc-logger" .. ctx.conf_id + local version = tostring(logger.filter) Review Comment: But the meaning of `version` here should be related to `filter`. If `conf` does not change but `filter` changed, then `version` should change and a new expr should be generated? However, as currently designed, if the `conf` is changed via the admin api, the `filter` will also change and use the new memory address. I was trying to make the place more intuitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
