tao12345666333 commented on code in PR #1009:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1009#discussion_r868854008
##########
pkg/kube/apisix/apis/config/v2/types.go:
##########
@@ -355,6 +365,23 @@ type ApisixConsumerKeyAuthValue struct {
Key string `json:"key" yaml:"key"`
}
+// ApisixConsumerJwtAuth defines the configuration for the jwt auth.
+type ApisixConsumerJwtAuth struct {
+ SecretRef *corev1.LocalObjectReference `json:"secretRef,omitempty"
yaml:"secretRef,omitempty"`
+ Value *ApisixConsumerJwtAuthValue `json:"value,omitempty"
yaml:"value,omitempty"`
+}
+
+// ApisixConsumerJwtAuthValue defines the in-place configuration for jwt auth.
+type ApisixConsumerJwtAuthValue struct {
+ Key string `json:"key" yaml:"key"`
+ Secret string `json:"secret,omitempty" yaml:"secret,omitempty"`
+ PublicKey string `json:"public_key,omitempty"
yaml:"public_key,omitempty"`
+ PrivateKey string `json:"private_key" yaml:"private_key,omitempty"`
+ Algorithm string `json:"algorithm,omitempty"
yaml:"algorithm,omitempty"`
+ Exp int64 `json:"exp,omitempty" yaml:"exp,omitempty"`
Review Comment:
exp is a positive number, I think you should add a check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
