tao12345666333 commented on code in PR #1009:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1009#discussion_r868969751
##########
pkg/kube/translation/plugin.go:
##########
@@ -115,6 +116,9 @@ func (t *translator)
translateConsumerBasicAuthPlugin(consumerNamespace string,
func (t *translator) translateConsumerJwtAuthPlugin(consumerNamespace string,
cfg *configv2beta3.ApisixConsumerJwtAuth) (*apisixv1.JwtAuthConsumerConfig,
error) {
if cfg.Value != nil {
+ if cfg.Value.Exp < 0 {
Review Comment:
https://github.com/apache/apisix/blob/ab7a7675d2a1abb1f0299a8fd44e5f80435c2158/apisix/plugins/jwt-auth.lua#L66
the minimum is 1
##########
pkg/kube/translation/plugin.go:
##########
@@ -141,6 +145,9 @@ func (t *translator)
translateConsumerJwtAuthPlugin(consumerNamespace string, cf
}
expRaw := sec.Data["exp"]
exp, _ := strconv.ParseInt(string(expRaw), 10, 64)
+ if exp < 0 {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
