barchielAbyss commented on PR #1109: URL: https://github.com/apache/apisix-website/pull/1109#issuecomment-1133815882
> > I think use shell run githook is not good, can i write in package.json like this? > > All transactions will eventually run as a shell after parsing. > > If I remember correctly, so why is it _not good_? We don't have to rewrite everything in JS. We may need many stages of checks, such as `pre-commit`, `commit-msg`, if different files are required to maintain it with shell commands, the check stage is likely to be added according to certain conditions, so that the new file There will be more and more. If it is your design idea to maintain the stage through files, I think it is feasible, but I recommend only changing the rules of the content of the checked files, rather than adding new files to add process configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
