barchielAbyss commented on PR #1109: URL: https://github.com/apache/apisix-website/pull/1109#issuecomment-1133816229
> Sorry, I need to point out some problems. > > Before you do something, please consider as much as possible whether we really need these improvements, and if you don't know, please create a proposal. > > For example, do we really need a configuration for vscode? Does your configuration work for everyone? I think the answer is obviously no. > > For example, does the addition of jest make sense? Does it cover all use cases that need to be tested? > > There are other problems that I don't want to enumerate. > > Also, I recommend doing one thing per PR, not everything. I understand your concern about why the `vscode` folder needs to be uploaded. It is because everyone may modify the code of this project, so you should provide a basic configuration of the vscode for this project, which may increase Your code review work, see if anyone has modified this file, but the advantage of this is that everyone will have a default configuration in the project's workspace, which can greatly reduce their configuration of this project time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
