stillfox-lee commented on code in PR #1056:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1056#discussion_r887443915


##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -803,6 +803,22 @@ spec:
                         required:
                           - serviceName
                           - servicePort
+                      plugins:
+                        type: array
+                        items:
+                          type: object
+                          properties:
+                            name:
+                              type: string
+                              minLength: 1
+                            enable:
+                              type: boolean
+                            config:
+                              type: object
+                              x-kubernetes-preserve-unknown-fields: true # we 
have to enable it since plugin config

Review Comment:
   Thanks for your review! I just copy this field from HTTP route: 
https://github.com/apache/apisix-ingress-controller/blob/deb044039e889e88310523f369833bb137c0e145/samples/deploy/crd/v1/ApisixRoute.yaml#L733-L745
   
   Three are three `plugin` field defiend for HTTP route in this yaml before my 
change. So, may be keep the same for Stream route?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to