stillfox-lee commented on code in PR #1056:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1056#discussion_r887453538


##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -803,6 +803,22 @@ spec:
                         required:
                           - serviceName
                           - servicePort
+                      plugins:
+                        type: array
+                        items:
+                          type: object
+                          properties:
+                            name:
+                              type: string
+                              minLength: 1
+                            enable:
+                              type: boolean
+                            config:
+                              type: object
+                              x-kubernetes-preserve-unknown-fields: true # we 
have to enable it since plugin config

Review Comment:
   > We can keep it consistent for now
   
   Any suggestion to make it better? I also think copy and paste are ugly. But 
I don't know how to improve it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to