bzp2010 commented on code in PR #2460:
URL: https://github.com/apache/apisix-dashboard/pull/2460#discussion_r902114481


##########
api/internal/handler/data_loader/loader/openapi3/openapi3.go:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package openapi3
+
+import (
+       "regexp"
+
+       "github.com/getkin/kin-openapi/openapi3"
+)
+
+type OpenAPISpecFileType string
+
+type Loader struct {
+       // MergeMethod indicates whether to merge routes when multiple HTTP 
methods are on the same path
+       MergeMethod bool
+       // TaskName indicates the name of current import/export task
+       TaskName string
+}
+
+type PathValue struct {
+       Method string
+       Value  *openapi3.Operation
+}
+
+var (
+       regURIVar              = regexp.MustCompile(`{[\w.]*}`)

Review Comment:
   The content in the search engine says `\w` contains `.`. However, after 
testing, if I use the regular expression `{\w*}`, it doesn't actually match, so 
I need to manually append the symbols `.`.
   
   Use `{\w*}`:
   
![image](https://user-images.githubusercontent.com/8078418/174705158-948d7abb-d0df-43fa-b6cd-d96bf44395a8.png)
   
   Use `{[\w.]*}`
   
![image](https://user-images.githubusercontent.com/8078418/174705304-5b67053c-2a93-4a3b-a74f-db6547371bc3.png)
   
   So I don't think it needs to be modified? If I have any other mistakes, 
please point them out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to