bzp2010 commented on code in PR #2460: URL: https://github.com/apache/apisix-dashboard/pull/2460#discussion_r902136600
########## api/internal/handler/data_loader/loader/openapi3/import.go: ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package openapi3 + +import ( + "errors" + "fmt" + "net/url" + "reflect" + "strings" + "time" + + "github.com/getkin/kin-openapi/openapi3" + + "github.com/apisix/manager-api/internal/core/entity" + "github.com/apisix/manager-api/internal/handler/data_loader/loader" + "github.com/apisix/manager-api/internal/utils/consts" +) + +func (o Loader) Import(input interface{}) (*loader.DataSets, error) { + if input == nil { + return nil, errors.New("input is nil") + } + + d, ok := input.([]byte) + if !ok { + return nil, fmt.Errorf("input format error: expected []byte but it is %s", reflect.TypeOf(input).Kind().String()) Review Comment: > Is this an API and will be exposed to the client? If so, you need to use some standards to make sure the data type is correct, such as jsonschema. If not, it means this method will be called by another internal method, and it's that handler's responsibility to make sure it accepts correct data type from the client and pass them to this method. As a result, when this method accepts bad data type, it could be classified to the programming fault. Get it, I will change it to panic and move the conversion check logic to the handler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
