AlinsRan commented on code in PR #1103:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1103#discussion_r911691025
##########
test/e2e/suite-ingress/webhook.go:
##########
@@ -64,11 +54,35 @@ spec:
break_response_code: 100 # should in [200, 599]
`, backendSvc, backendPorts[0])
- err := s.CreateResourceFromString(ar)
- assert.Error(ginkgo.GinkgoT(), err, "Failed to create
ApisixRoute")
- assert.Contains(ginkgo.GinkgoT(), err.Error(), "admission
webhook")
- assert.Contains(ginkgo.GinkgoT(), err.Error(), "denied the
request")
- assert.Contains(ginkgo.GinkgoT(), err.Error(), "api-breaker
plugin's config is invalid")
- assert.Contains(ginkgo.GinkgoT(), err.Error(), "Must be greater
than or equal to 200")
+ err := s.CreateResourceFromString(ar)
+ assert.Error(ginkgo.GinkgoT(), err, "Failed to create
ApisixRoute")
+ assert.Contains(ginkgo.GinkgoT(), err.Error(),
"admission webhook")
+ assert.Contains(ginkgo.GinkgoT(), err.Error(), "denied
the request")
+ assert.Contains(ginkgo.GinkgoT(), err.Error(),
"api-breaker plugin's config is invalid")
+ assert.Contains(ginkgo.GinkgoT(), err.Error(), "Must be
greater than or equal to 200")
+ })
+ }
+
+ ginkgo.Describe("suite-ingress: scaffold v2beta3", func() {
+ suites(scaffold.NewScaffold(&scaffold.Options{
+ Name: "webhook",
+ Kubeconfig: scaffold.GetKubeconfig(),
+ APISIXConfigPath: "testdata/apisix-gw-config.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort: 80,
+ ApisixResourceVersion:
scaffold.ApisixResourceVersion().V2beta3,
+ EnableWebhooks: false,
+ }))
+ })
+ ginkgo.Describe("suite-ingress: scaffold v2", func() {
+ suites(scaffold.NewScaffold(&scaffold.Options{
+ Name: "webhook",
+ Kubeconfig: scaffold.GetKubeconfig(),
+ APISIXConfigPath: "testdata/apisix-gw-config.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort: 80,
+ ApisixResourceVersion:
scaffold.ApisixResourceVersion().V2,
+ EnableWebhooks: false,
+ }))
Review Comment:
This is to identify `enablewebhooks`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
