AlinsRan commented on code in PR #1103:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1103#discussion_r911699747
##########
test/e2e/scaffold/scaffold.go:
##########
@@ -541,12 +564,19 @@ func (s *Scaffold) FormatNamespaceLabel(label string)
string {
var (
versionRegex = regexp.MustCompile(`apiVersion:
apisix.apache.org/v.*?\n`)
+ kindRegex = regexp.MustCompile(`kind: .*?\n`)
)
func (s *Scaffold) replaceApiVersion(yml, ver string) string {
return versionRegex.ReplaceAllString(yml, "apiVersion: "+ver+"\n")
}
+func (s *Scaffold) getKindValue(yml string) string {
+ kind := strings.Replace(kindRegex.FindString(yml), "\n", "", -1)
Review Comment:
> How about a fix in a follow-up PR? @AlinsRan
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
