juzhiyuan commented on code in PR #3021:
URL: https://github.com/apache/apisix/pull/3021#discussion_r913358013
##########
apisix/plugins/openid-connect.lua:
##########
@@ -148,6 +150,13 @@ end
function _M.rewrite(plugin_conf, ctx)
local conf = core.table.clone(plugin_conf)
+
+ -- Previously, we multiply conf.timeout before storing it in etcd.
+ -- If the timeout is too large, we should not multiply it again.
+ if not (conf.timeout >= 1000 and conf.timeout % 1000 == 0) then
Review Comment:
Hi @spacewander 👋 May I know why we need to use `multiply` here? 🤔 because
both our document[1] and code comments (`schema.description`) says it's in
`second`.
[1] https://apisix.apache.org/docs/apisix/next/plugins/openid-connect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
