ccxhwmy commented on code in PR #7412:
URL: https://github.com/apache/apisix/pull/7412#discussion_r917513467


##########
apisix/plugins/prometheus/exporter.lua:
##########
@@ -351,6 +356,42 @@ local function etcd_modify_index()
 
 end
 
+local key = {}
+local combine_param = {}

Review Comment:
   > can we init `key` and `combine_param` as table if `header_of_shared_dict` 
is true?
   
   I consider the problem of repeated malloc for table `key` and 
`combine_param`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to