ccxhwmy commented on code in PR #7412:
URL: https://github.com/apache/apisix/pull/7412#discussion_r917719974


##########
apisix/plugins/prometheus/exporter.lua:
##########
@@ -122,6 +123,10 @@ function _M.http_init(prometheus_enabled_in_stream)
             "Etcd modify index for APISIX keys",
             {"key"})
 
+    metrics.shared_dict = prometheus:gauge("shared_dict",
+            "nginx shared DICT of APISIX",
+            {"key"})

Review Comment:
   > 
   
   Modify the initialization with
   ```lua
       metrics.shared_dict_capacity_bytes = 
prometheus:gauge("shared_dict_capacity_bytes",
               "nginx shared DICT capacity of APISIX",
               {"name"})
   
       metrics.shared_dict_free_space_bytes = 
prometheus:gauge("shared_dict_free_space_bytes",
               "nginx shared DICT free_space of APISIX",
               {"name"})
   ```
   Is my understanding correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to