ccxhwmy commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r919803607
########## apisix/plugins/prometheus/exporter.lua: ########## @@ -352,13 +360,50 @@ local function etcd_modify_index() end +local function shared_dict_status() + local attr = plugin.plugin_attr(plugin_name) Review Comment: > We can list the shdict in https://github.com/apache/apisix/blob/master/apisix/cli/ngx_tpl.lua, instead of requiring the users to configure them? Since the usage of shdict is an implementation detail. This is what I was trying to do at first, but I don't know how to get all the shdicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
