Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1220: print nested values using visitors ......................................................................
Patch Set 15: (6 comments) I think that we can live with these SonarQube complaints ... https://asterix-gerrit.ics.uci.edu/#/c/882/15/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java: Line 111: public static void printYearMonthDurationString(byte[] b, int s, int l, PrintStream ps) > MAJOR SonarQube violation: Yes, but that's the signature for all methods in this class ... https://asterix-gerrit.ics.uci.edu/#/c/882/15/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java: Line 41: public static boolean printFlatValue(ATypeTag typeTag, byte[] b, int s, int l, PrintStream ps) > MAJOR SonarQube violation: Not sure how to make this any simpler ... Line 137: return (byte[] b, int s, int l, PrintStream ps) -> { > MAJOR SonarQube violation: Not sure how to do this ... https://asterix-gerrit.ics.uci.edu/#/c/882/15/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AObjectPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AObjectPrinterFactory.java: Line 40: public static boolean printFlatValue(ATypeTag typeTag, byte[] b, int s, int l, PrintStream ps) > MAJOR SonarQube violation: Not sure how to make this any simpler ... https://asterix-gerrit.ics.uci.edu/#/c/882/15/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java: Line 41: public static boolean printFlatValue(ATypeTag typeTag, byte[] b, int s, int l, PrintStream ps) > MAJOR SonarQube violation: Not sure how to make this any simpler ... https://asterix-gerrit.ics.uci.edu/#/c/882/15/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AObjectPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AObjectPrinterFactory.java: Line 41: public static boolean printFlatValue(ATypeTag typeTag, byte[] b, int s, int l, PrintStream ps) > MAJOR SonarQube violation: Not sure how to make this any simpler ... -- To view, visit https://asterix-gerrit.ics.uci.edu/882 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I692c04dd1b3aa8e7adccfe960615f0fc2df6fe26 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
