Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1220: print nested values using visitors ......................................................................
Patch Set 17: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/882/17/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AOrderedlistPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AOrderedlistPrinterFactory.java: Line 39: private AOrderedListType orderedlistType; > final? Done Line 47: final PointableAllocator allocator = new PointableAllocator(); > private final for all fields? These are local variables in the method that become members. Those can't have access modifiers. Line 52: final Pair<PrintStream, ATypeTag> arg = new Pair<PrintStream, ATypeTag>(null, null); > Pair<PrintStream, ATypeTag> --> Pair<>? Done https://asterix-gerrit.ics.uci.edu/#/c/882/17/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AOrderedlistPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AOrderedlistPrinterFactory.java: Line 48: final IAType inputType = orderedlistType == null > private final? Done Line 50: final IVisitablePointable listAccessor = allocator.allocateListValue(inputType); > private final? Access modifiers not allowed here. -- To view, visit https://asterix-gerrit.ics.uci.edu/882 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I692c04dd1b3aa8e7adccfe960615f0fc2df6fe26 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
