Ian Maxon has posted comments on this change. Change subject: Update adm.grammar and printers for double/float ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/932/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java: Line 33: .print(ADoubleSerializerDeserializer.getDouble(b, s + 1)); > Don't we lose some fidelity by omitting the 'd' and 'f' suffixes? Should w It assumes double by default so, at worst you might up-cast a float into a double, if you don't specify a schema. I think there might be a way to allow NaN/Infinity with suffixes, but it'd look pretty odd and I don't know if that's what we want to do. Before, this was totally broken, because adm.grammar did not accept the 'd' suffix. -- To view, visit https://asterix-gerrit.ics.uci.edu/932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
