Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1150: Update adm.grammar and printers for double/float ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/932/4/asterixdb/asterix-external-data/src/main/resources/adm.grammar File asterixdb/asterix-external-data/src/main/resources/adm.grammar: Line 97: FLOAT_LITERAL = signOrNothing(), digitSequence(), token(@EXPONENT), caseInsensitiveChar(f) The previous version of the grammar seems to contain less duplication. Is there a reason not to factor common pieces out? Also, could you remove the tabs? -- To view, visit https://asterix-gerrit.ics.uci.edu/932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
