Yingyi Bu has posted comments on this change. Change subject: Fix Decoding of byte[] Records ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java: Line 42: public class DCPMessageToRecordConverter implements IRecordToRecordWithMetadataAndPKConverter<DCPRequest, char[]> { > If by Style, you mean the formatting? then I think so. I mean formatting. Right, I double checked. It's correct. Line 116: bytes.compact(); > the SDK use netty byte buffer which id different from java ByteBuffer. the How many copies are done for each buffer, roughly? i.e., how many times compact() is called for each frame? -- To view, visit https://asterix-gerrit.ics.uci.edu/951 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
