Yingyi Bu has posted comments on this change. Change subject: Fix Decoding of byte[] Records ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java: Line 116: bytes.compact(); > Once per record. However, this is mostly a no op. it is only an op if the d That's going to be a lot of copies if I understand correctly... You end up copying half of frame k times, where k is the number of records within that frame. "half-of-frame" is the mathematical expectation. For example, you have 100 records for a 32KB frame, you'll copy 1.6MB data for each frame: 100 * (32KB/2). Am I correct? How many frames will flow through this set call? Is it proportional to the data volume? -- To view, visit https://asterix-gerrit.ics.uci.edu/951 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
