Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-1375 - New Query UI implementation ......................................................................
Patch Set 7: (2 comments) A few quick comments, I would try addressing the rest of the SonarQube comments as well as being sure there's an appropriate copyright header on every new file for this. https://asterix-gerrit.ics.uci.edu/#/c/935/7/asterixdb/asterix-app/src/main/resources/newui/js/aql-mode.js File asterixdb/asterix-app/src/main/resources/newui/js/aql-mode.js: Line 2: Where did you derive the grammar for this from? Is it from AQL.jj? https://asterix-gerrit.ics.uci.edu/#/c/935/7/asterixdb/asterix-app/src/main/resources/newui/js/main.js File asterixdb/asterix-app/src/main/resources/newui/js/main.js: Line 1: var SERVER_HOST = "http://"+location.hostname+":19002";; This port should be somehow derived from the CC's properties. It isn't always 19002. -- To view, visit https://asterix-gerrit.ics.uci.edu/935 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Kaveen Rodrigo <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
