Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1375 - New Query UI implementation ......................................................................
Patch Set 7: (1 comment) Just a few comments so far: I think that would should find a more descriptive name than "newui". "Newui"will get old soon and then we're stuck with a strange name. Is there a more technical name for the package? Since we've got potentially new outside code here (Angular, Bootstrap, ...) we need to find out what needs to be added to the LICENSE and NOTICE for it. https://asterix-gerrit.ics.uci.edu/#/c/935/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java: Line 42: public class QueryWebInterfaceServlet extends HttpServlet { I think that this Servlet only serves static resources. Is that right? If so, could we call it something like "StaticResourceServlet"? I think that this would make it clearer what it does. Also it seems that the functionality might be useful to support other interfaces than the query web interface and a generic name could help to express that. -- To view, visit https://asterix-gerrit.ics.uci.edu/935 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Kaveen Rodrigo <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
