Michael Blow has posted comments on this change. Change subject: Update adm.grammar and printers for double/float ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/932/6/asterixdb/asterix-external-data/src/main/resources/adm.grammar File asterixdb/asterix-external-data/src/main/resources/adm.grammar: Line 90: FLOAT_LITERAL = token(DOUBLE_LITERAL), caseInsensitiveChar(f) These last two patchsets introduce NaN[fd], [-]Infinity[fd]. Do we want these to be parseable double/float literals? Also, the tabs are still in :-P -- To view, visit https://asterix-gerrit.ics.uci.edu/932 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
