abdullah alamoudi has posted comments on this change. Change subject: ASTERIXDB-1494: refactor ExternalLibraryManager and make it non-static. ......................................................................
Patch Set 4: One comment: I would suggest we remove the libraryManager from the call to configure() on IParserFactory. There are two reasons: 1. It is not really needed by any of the existing parser factories (Nor I see a need for it in future uses). 2. It is an extendible interface that a user might extend to provide their own parser implementation and it will be confusing for a user to see this parameter (which I would argue they don't need anyway). -- To view, visit https://asterix-gerrit.ics.uci.edu/980 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c287a35ff90c3aea639d3069d5a842e28c5e508 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
