Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1269 Fix Extraction of Query Segment and Refactor AQL Parser ......................................................................
Patch Set 2: (10 comments) Found a few more spaces, but those are not important. The question that confuses me (and that I didn't see last time) is why <NOT> is an identifier? What's the explanation for this? https://asterix-gerrit.ics.uci.edu/#/c/988/2/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj: Line 426: (<ON> nodeGroupName = Identifier() )? space missing Line 467: (<AUTOGENERATED> { autogenerated = true; } )? space missing Line 468: (<ON> nodeGroupName = Identifier() )? space missing Line 604: (<BTREE> space missing Line 657: <FUNCTION>fctName = FunctionName() space missing Line 689: <SECONDARY> <FEED> nameComponents = QualifiedName() ifNotExists = IfNotExists() 2 spaces Line 720: <INGESTION> <POLICY> policyName = Identifier() ifNotExists = IfNotExists() 2 spaces Line 812: fctName = FunctionName() <SYMBOLAT><INTEGER_LITERAL> space missing Line 1332: (<SYMBOLHASH> third = Identifier())? | <SYMBOLHASH> second = Identifier() )? space missing Line 1381: ((<IDENTIFIER>|<NOT>) Why is NOT an identifier? -- To view, visit https://asterix-gerrit.ics.uci.edu/988 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18ac4f8d86b3c5c7bfe226c98114499671649e93 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
