Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1269 Fix Extraction of Query Segment and Refactor AQL Parser ......................................................................
Patch Set 2: (1 comment) Can you add a SQL++ query as a regression test? It seems to me that the SQL++ query should just work because you fixed that in ScopeChecker. https://asterix-gerrit.ics.uci.edu/#/c/988/2/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj: Line 1381: ((<IDENTIFIER>|<NOT>) It's better to change test queries, instead of hacking identifiers here. For those queries calling function not(....), do the following change: not -> "not", i.e., to use delimited identifiers. -- To view, visit https://asterix-gerrit.ics.uci.edu/988 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18ac4f8d86b3c5c7bfe226c98114499671649e93 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
