Xikui Wang has posted comments on this change. Change subject: TweetParser Extension ......................................................................
Patch Set 4: @Abdullah, I checked the TwitterObjectFactory.getRawJSON method. When the JsonStoreEnabled is turned on. The TwitterObjectFactory will maintain an internal map which maps the existed Status object to JSON string, thus I think it will not trigger two requests to Twitter. On the performance side, my actual concern is that I created one JSONObject per record, which may cause memory overhead. The reason to use JSONObject is in order to iterate over all fields. I couldn't find any other workaround on that part. Any suggestions? For the test case part, the test cases I understood are the queries under asterixdb/asterixdb/asterix-app/src/test/resources/runtimets . I think you are referring to test cases elsewhere using mock objects. Any existed test case that I can refer to? I will put my test queries under the queries section. -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
