Till Westmann has posted comments on this change. Change subject: TweetParser Extension ......................................................................
Patch Set 4: (2 comments) @Xikui Yes, semantically it is correct to have no block around single line statements. However, it does sometimes help to avoid issues when fixing code and adding a line to the else. But more importantly than that we're working on becoming more consistent about code-style. When reviewing code or looking at old commits it helps a lot if all the changes that you see are actually changes to the content of the code and not interspersed with changes to the format. That's why we have a common code formatter for Eclipse (that can also be used e.g. in IntelliJ IDEA) and the SonarQube reminders. Does that make sense? https://asterix-gerrit.ics.uci.edu/#/c/1002/4//COMMIT_MSG Commit Message: Line 15: 3. Fixed bug ASTERIXDB-1471. Please remove this from the message as you've fixed it separately. https://asterix-gerrit.ics.uci.edu/#/c/1002/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java: Line 224: public static final String READER_RSS = "rss_feed"; One question on fixing ASTERIXDB-1352: It seems that we have the choice of either fixing the code or the docs. If so, I’d have a slight preference towards fixing the docs. Thoughts? -- To view, visit https://asterix-gerrit.ics.uci.edu/1002 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
