Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File ......................................................................
Patch Set 6: (55 comments) Most comments are one the comments for the tests. There's quite q bit of strange whitespace in there. Also the comments often seem unrelated to the test ... https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Also, this seems to use the file adapter, not a simulator. Line 21: Begin ingestion and verify contents of the dataset post completion. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Also, this seems to use the file adapter, not a simulator. Line 21: Begin ingestion and verify contents of the dataset post completion. WS Line 25: WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Also, this seems to use the file adapter, not a simulator. Line 21: Begin ingestion and verify contents of the dataset post completion. WS Line 25: WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp: Line 20: * Description : Create a feed dataset with an associated function and verify contents in Metadata Where does the content verification in Metadata happen? Line 35: } WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.1.ddl.sqlpp: Line 21: Create a dataset that has an associated rtree index. There seems to be no index created ... Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. Is "twitter_firehose" a synthetic feed simulator? https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.2.update.sqlpp: Line 20: * Description : Create a feed using the synthetic feed simulator adapter. WS Other comments as before. https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.3.query.sqlpp: Line 20: * Description : Create a feed using the synthetic feed simulator adapter. WS Other comments as before. Line 32: case WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.1.ddl.sqlpp: Line 22: The synthetic feed simulator uses the Social-Data generator Again, wondering if twitter_firehose is a synthetic feed. https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.2.update.sqlpp: Line 22: The synthetic feed simulator uses the Social-Data generator Comment as before. https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.3.query.sqlpp: Line 22: The synthetic feed simulator uses the Social-Data generator Comment as before. Line 34: case WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.4.sleep.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.4.sleep.sqlpp: Line 22: The synthetic feed simulator uses the Social-Data generator Comment as before. https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.1.ddl.sqlpp: Line 20: * Description : Create a feed using the synthetic feed simulator adapter. WS Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. WS Comment as before. Line 23: The feed lasts a configured duration with data arriving at a configured rate (tweets per second). WS Line 25: * Issue : 711 WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.2.update.sqlpp: Line 20: * Description : Create a feed using the synthetic feed simulator adapter. WS Comment as before. Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. WS Line 25: * Issue : 711 WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.3.query.sqlpp: Line 20: * Description : Create a feed using the synthetic feed simulator adapter. WS Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. WS Line 23: The feed lasts a configured duration with data arriving at a configured rate (tweets per second). WS Line 25: * Issue : 711 WS Line 32: case WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.1.ddl.sqlpp: Line 21: Create a feed that uses the file_feed adapter. Adapter is called "localfs" now? https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.2.update.sqlpp: Line 21: Create a feed that uses the file_feed adapter. Comment as before. https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.3.query.sqlpp: Line 21: Create a feed that uses the file_feed adapter. Comment as before. https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.4.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.4.ddl.sqlpp: Line 21: Create a dataset that has an associated ngram index. ?? no ngrams here, are there? https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.1.ddl.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Line 21: Begin ingestion using a fully qualified name and verify contents of the dataset post completion. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.2.update.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Line 21: Begin ingestion using a fully qualified name and verify contents of the dataset post completion. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.3.query.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Line 21: Begin ingestion using a fully qualified name and verify contents of the dataset post completion. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.1.ddl.sqlpp: Line 20: * Description : Create a feed from the contents of a file using a file_feed adaptor. WS Line 23: without an abort. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.2.update.sqlpp: Line 20: * Description : Create a feed from the contents of a file using a file_feed adaptor. WS Line 23: without an abort. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.3.query.sqlpp: Line 20: * Description : Create a feed from the contents of a file using a file_feed adaptor. WS Line 23: without an abort. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.4.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.4.ddl.sqlpp: Line 22: The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. Comment is for anoethr test. https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.1.ddl.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS seems to be localfs ... Line 21: Begin ingestion using a fully qualified name and verify contents of the dataset post completion. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.2.update.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Line 21: Begin ingestion using a fully qualified name and verify contents of the dataset post completion. WS https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.3.query.sqlpp: Line 20: * Description : Create a feed dataset that uses the feed simulator adapter. WS Line 21: Begin ingestion using a fully qualified name and verify contents of the dataset post completion. WS -- To view, visit https://asterix-gerrit.ics.uci.edu/1018 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
