Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
......................................................................


Patch Set 7: Code-Review+2

(9 comments)

So happy you left some whitespace in there for me to find.

https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS


Line 21:                   Begin ingestion and verify contents of the dataset 
post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS


Line 21:                   Begin ingestion and verify contents of the dataset 
post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS


Line 21:                   Begin ingestion and verify contents of the dataset 
post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp:

Line 35: }      
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to