Yingyi Bu has posted comments on this change. Change subject: Add Record Literal and Byte Array Value Reference ......................................................................
Patch Set 1: (3 comments) What's the motivation or introducing the two new classes? - Literal is a parser concept. Currently we don't parse records or lists directly in the AQL or SQL++ parser, but as constructor expressions. - The functionality of ByteArrayValueReference seems not much different from VoidPointable? - It seems their constructors are not called. https://asterix-gerrit.ics.uci.edu/#/c/1098/1/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/Literal.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/Literal.java: Line 39: RECORD Literal is a parser concept. We don't parse records or lists directly in the AQL or SQL++ parser. For example, you can take a look at: asterixdb/asterixdb/asterix-lang-sqlpp/target/site/jjdoc/SQLPP.html https://asterix-gerrit.ics.uci.edu/#/c/1098/1/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/literal/RecordLiteral.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/literal/RecordLiteral.java: Line 29: public RecordLiteral(ARecord record) { It seems nobody calls this constructor. https://asterix-gerrit.ics.uci.edu/#/c/1098/1/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/data/accessors/ByteArrayValueReference.java File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/data/accessors/ByteArrayValueReference.java: Line 23: public class ByteArrayValueReference implements IValueReference { What's the difference of this class with VoidPointable? It seems nobody calls this constructor. -- To view, visit https://asterix-gerrit.ics.uci.edu/1098 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25c5054a361128a3bee4241d7b9b40da7e61373f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
