Michael Blow has posted comments on this change. Change subject: Add Record Literal and Byte Array Value Reference ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1098/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/literal/RecordLiteral.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/literal/RecordLiteral.java: Line 47: return super.equals(o) && ObjectUtils.equals(record, ((RecordLiteral) o).record); these two checks are redundant -- To view, visit https://asterix-gerrit.ics.uci.edu/1098 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25c5054a361128a3bee4241d7b9b40da7e61373f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes