Till Westmann has posted comments on this change. Change subject: Refactor Active Listeners ......................................................................
Patch Set 3: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1118/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java: Line 87: if (dataSource instanceof IMutationDataSource) { It seems that we got something wrong here - we should be able to get enough information from the data source about its type without using instanceof ... https://asterix-gerrit.ics.uci.edu/#/c/1118/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 1416: if (listener.isEntityConnectedToDataset(dataverseName, datasetName)) { For indexes it seems that we can ask the metadata manager which indexes are associated with the dataset. Shouldn't that be similar here? What's the difference? Line 3113: if (mdTxnCtx != null) { How do we get to the place where the ctx is null? Sounds scary ... https://asterix-gerrit.ics.uci.edu/#/c/1118/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java: Line 646: public boolean isEntityConnectedToDataset(String dataverseName, String datasetName) { Hmm, why is it ok to ignore the dataverse? https://asterix-gerrit.ics.uci.edu/#/c/1118/3/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java: Line 35: public boolean isLeaf(); Hmm, shouldn't the "leaf" property be the property of an operator in the tree? It seems that that shouldn't be a property of a data source. I'm not completely sure what this property means - maybe we just need the right name? https://asterix-gerrit.ics.uci.edu/#/c/1118/3/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 271: if (dataSource.isLeaf()) { The "leaf" property doesn't seem right here either. -- To view, visit https://asterix-gerrit.ics.uci.edu/1118 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I260c8608329523f56dc54780d87d796f838505cf Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
