Till Westmann has posted comments on this change. Change subject: Refactor Active Listeners ......................................................................
Patch Set 4: Code-Review+2 (2 comments) Please use the +2 once you've filed the issue and either addressed the IDataSource interface or filed an issue for it. https://asterix-gerrit.ics.uci.edu/#/c/1118/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java: Line 90: && dataSource.getDatasourceType() != AqlDataSourceType.LOADABLE) { We need a cleaner design around datasource types and mutability. There should be an extensible way to have data source types that either provide or not provide mutations. Could you file an issue? https://asterix-gerrit.ics.uci.edu/#/c/1118/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java: Line 35: public boolean isScanAccessPathALeaf(); Just talked a bit with Yingyi and the property here seems to be that the operator that scans the datasource can be "driven" by another operator (like a dataset scan) or not (like a feed, where the adapter does the driving). Also talked with Mike and one proposal that we can up with is "isActive()" as active datasources like feeds really have to be leafs while passive datasources like datasets can be scanned by inner nodes. Would that work? -- To view, visit https://asterix-gerrit.ics.uci.edu/1118 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I260c8608329523f56dc54780d87d796f838505cf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
