Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin. ......................................................................
Patch Set 11: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1119/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java: Line 159: for (int i = 0; i < joinOp.getInputs().size(); i++) { Move the unnest-map gathering/check to line 189. Add a method isParentOfUnnestMap(...) to just check if an operator is the parent of an unnestmap. Call isParentOfUnnestMap(joinOp.getInputs().get(unusedJoinBranchIndex).getValue()) to check the condition at line 189. One more question: Should the condition be more general than unnest-map? Any cardinality reduction operator should be qualified here? E.g., SELECT etc. -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
