Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1487: fix the wrong plan when we purning the selective branch. ......................................................................
Patch Set 13: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1119/13//COMMIT_MSG Commit Message: Line 7: ASTERIXDB-1487: fix the wrong plan when we purning the selective branch. purning -> prune Line 10: 2. Disable the join branch pruning in case of unnestmap following datasourcescan. "unnestmap" -> "operators that do not preserve cardinality" https://asterix-gerrit.ics.uci.edu/#/c/1119/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java: Line 120: private int removeJoinFromInputBranch(Mutable<ILogicalOperator> opRef, int startBranch) throws AlgebricksException { Is variable startBranch necessary? Why it didn't work without this parameter? Line 196: return removeJoinFromInputBranch(opRef, 1); What's the purpose of the recursive call here? Line 202: AbstractLogicalOperator op = (AbstractLogicalOperator) opRef.getValue(); Call op.getOperatorTag() once after line 202. -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
