Preston Carman has posted comments on this change. Change subject: Updated DeletableFrameTupleAppender to support reusing index slots. ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1214/1/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/IntegerPair.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/IntegerPair.java: Line 24: public class IntegerPair implements Serializable { > A silly question - why do we need this separate class instead of using Pair We do not need a separate class. My thought was this class would cut down on objects since it uses ints instead of Integers. I guess the name should reflect the actual data type. Thoughts on removing this class in favor of Pair or changing the name to IntPair. -- To view, visit https://asterix-gerrit.ics.uci.edu/1214 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05cda3360cc503bf847aeca5998be06f1f7d3c15 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
