Taewoo Kim has posted comments on this change. Change subject: Updated DeletableFrameTupleAppender to support reusing index slots. ......................................................................
Patch Set 2: Before going into the detail, I would like to add my two-cent thoughts since I'm little bit worried about extra space usage per each slot. It seems like this DeletableFrameTupleAppender is used in heap sort. I think changing this affects the performance. Can you do some performance test to show that this change doesn't degrade the performance for general heap-sort? Also, if it affects the performance, can we extend this class to create a new appender that includes your design here? -- To view, visit https://asterix-gerrit.ics.uci.edu/1214 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05cda3360cc503bf847aeca5998be06f1f7d3c15 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: No
