Michael Blow has posted comments on this change. Change subject: NC Shutdown Hangs On Stuck Work, Tweak Shutdown Timeouts ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1217/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java: Line 77: thread.interrupt(); > What's the advantage of interrupting over "flushing" the queue? Two birds, one stone. The interrupt is required to expedite work that is executing. If no work is executing, the interrupt will break the take() so we don't need to kick the queue to discover the stopped condition. https://asterix-gerrit.ics.uci.edu/#/c/1217/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java: Line 620: LOGGER.warning("Exception in executing shutdown hook" + e); > Shouldn't we log(WARN, message, exception)? oops; done -- To view, visit https://asterix-gerrit.ics.uci.edu/1217 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12a9577c570c095afeac882664d29f0c8f53a4ad Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
